heroicon
heroicon copied to clipboard
bharget
Reduce Rails Dependencies to Railties
Fixes #32
This PR removes a large amount of rails dependencies to what is required by heroicon.
The whole dummy application was not required. It even hid a configuration setup for Heroicon that set up a test. That has been fixed.
The process was fairly simple. Check the Gemfile.lock into git so that I can track dependency removal and explicitly add each rails dependency. Then I went and individually removed each one until I figured out what was really going on. The dummy application, which wasn't even used, required the rails deps. So I commented out loading the dummy application and some more active storage configs in the test helper and reran the tests. A single failure was noticed and it just needed a configuration setup.
−1,832 lines removed in exchange for +12 new lines.
@bharget I'm sure you're very busy, but just giving this change another bump.
@BenMorganIO I've forked this as mentioned in #37 and really liked this. If you open this against https://github.com/jclusso/heroicon-ruby, I'll get it merged in. This gem has way to many unnecessary dependencies.
@BenMorganIO I've started work incorporating your changes into a PR. https://github.com/jclusso/heroicons/pull/6