Bharath Appali

Results 44 comments of Bharath Appali

I feel the changes required include removing the download and installation of external [GLIBC](https://github.com/AdoptOpenJDK/openjdk-docker/blob/master/11/jdk/alpine/Dockerfile.hotspot.nightly.full#L26) for hotspot images. Please lemme know if i had missed anything.

Thanks for pointing it @mpirvu , I feel `Append the user provided options to the ones set in the container` will be a good approach as its a OpenJ9 specific...

@mpirvu As `-Xshareclasses` is an OpenJ9 specific option I feel it should be added to the `OPENJ9_JAVA_OPTIONS`, I do accept there are downsides as you mentioned it can be overridden,...

> It's cumbersome for someone to lookup the container definition to see in detail what it does I do accept its an extra effort for a user to have a...

> If we append SCC options how would the user override them if they needed to? Thanks for raising this point, the SCC option should be prepended so if the...

I'm not sure if it's the problem with `openjdk-docker` images, the setting your are trying will be changing the file `/proc/sys/vm/max_map_count` which is `procfs`, I feel docker mounts `procfs` as...

@karianna Extending this PR to have changes for dynamic params instead of current positional args. Will update you once its ready for review.

> Perhaps this process of regenerating files could be automatically triggered by a merge to the master branch? @sgerrand @karianna i personally use [this script](https://github.com/bharathappali/handy-utils/blob/master/update_dockerfiles_on_merge.sh) to make that automation when...

Exploration done till now (Adding here for quick reference): https://github.com/AdoptOpenJDK/openjdk-tests/issues/2031#issuecomment-719985342 https://github.com/AdoptOpenJDK/openjdk-tests/issues/2031#issuecomment-721591801

@sophia-guo I have raised an issue in OpenJ9 https://github.com/eclipse/openj9/issues/11110 I have pointed your issue in AdoptOpenJDK/openjdk-tests#2031 as it has more details than this issue in openjdk-docker repo.