András Bánki-Horváth
András Bánki-Horváth
Seems like the `.last-compacted` file was corrupted? Are you maybe running from an SD card?
Hi @ziggie1984, thanks for the report. We're aware and this is a known issue that is being worked on: https://gitlab.com/cznic/sqlite/-/issues/180
I'm not 100% about this approach. Another would be to more explicitly flag changes in the update contexts as currently we pass around the changed invoice and assume that the...
Please take reviews on-hold while I'm working on a larger refactor to accommodate suggestions by Laolu. Will move out of draft when ready for another look.
> > Really important and also difficult PR you are working on, respect 🤝 ! > > I like your approach and how you separated a lot of data from...
Thanks @Roasbeef @yyforyongyu @positiveblue for the insightful comments! Tried to make everything better based on your suggestions. PTAL (and also please check the next PR https://github.com/lightningnetwork/lnd/pull/8052 for more context).
> IMO this is good to go once the questions and the potential nil panic are resolved. It'd be great to have this merged so we can focus on its...
Let me know if this is ready for another round :telescope: