Benny Halevy

Results 978 comments of Benny Halevy

Hi @tchaikov, sorry, I think I've beat you to the gong. Please see https://github.com/scylladb/seastar/pull/2305

@scylladb/seastar-maint please consider merging

@scylladb/seastar-maint please consider merging

> Doesn't it fix an open bug? The bug was opened in scylladb (https://github.com/scylladb/scylladb/issues/19227) so updating the seastar submodule should be marked as fixing it. I can open a corresponding...

- rebased (checkheaders issue seems to be fixed already in latest master)

> @bhalevy what's holding this one from getting merge ? Nothing, now that CI has passed. @scylladb/seastar-maint please merge

The problem is only with llvm-addr2line, right? The command you quoted works for me with /usr/bin/addr2line ``` $ addr2line --version GNU addr2line version 2.41-38.fc40 ```

> > cc @tgrabiec -- I think you mentioned at some point that we'd like to support going from 0 to N for new DCs, but that's something planned for...

@avikivity can this PR be merged from your perspective?

Can we please run a SCT test to compare backup performance under load before and after the change? Let's see that the change behaves well in practice. I hope that...