roostrap
roostrap copied to clipboard
bhagyas
CRUD buttons changed to be more compact and use glyphicons instead of vanilla famfamfam icons
This pull request contains the following tweaks for CRUD buttons found on site:
- made CRUD buttons use glyphicons bundled with Bootstrap instead of default famfamfam icons bundled with Roo. These icons look more Bootstrap-ish and fit much better into current UI.
- CRUD buttons in current version are too large, making UI look awkward in some places. Made them smaller.
Tested on: IE9,10,11, Chrome 32, FF 26
Thank you!
Tested it out and it looks great! What do you think about increasing the button size so it can be better touch targets when displayed on an iPad or a mobile device?
Haven't tried it on the Android/IOS devices, so cannot say anything specific right now. Will be able to test it and see how it looks in a few days.
... the only thing I can say right now, however, is that making icons bigger make list pages on desktop browsers look somewhat awkward to my taste (height of the the row seem too big). Maybe it is a good idea to leave small buttons on list pages and make other buttons (like ones on view pages) bigger.
Sorry for the lack of updates on this for a while. Tried this on Nexus 7 and iPhone 5s - buttons are not super large but clickable enough. Not seeing much sense in enlarging them at cost of making ui in general look more awkward on desktop.