Tone
Tone copied to clipboard
Use correct separator in keywords.txt
The Arduino IDE requires the use of a tab separator between the name and identifier. Without this tab the keyword is not highlighted.
Reference: https://github.com/arduino/Arduino/wiki/Arduino-IDE-1.5:-Library-specification#keywords
Hey @per1234 -- I'm not sure who put you up to this, but damn... that's gotta be a LOT of work to fork and fix all of those libraries with messed up keywords.txt files.
How about instead, we just fix the problem with the keyword loading? It was done a long time ago in Wiring, but it seems that Arduino never picked it up.
I've made the change and created a pull request to the Arduino repo: https://github.com/arduino/Arduino/pull/6693
Good job on that pull request! I don't see any benefit to requiring tabs for the separator and it's a pain for people who have their editor set up to use spaces instead of tabs.
I do think it's still worth making this change for the sake of backwards compatibility. It's surprising how many people are still using outdated versions of the Arduino IDE going back to 1.0.5 or older.