sylvia icon indicating copy to clipboard operation
sylvia copied to clipboard

WIP: 2to3

Open WillForan opened this issue 2 years ago • 1 comments

Still a work in progress, but wanted to link here in case motivation found anyone else.

  • The first commit runs 2to3 and black and can hopefully be ignored.
  • 65defa5660bba46cce2932a42dc45cd244868fe9 changes the splits to use bytes instead of strings
  • 35dbd9c537beb9407c258280fe527806b284966e has working findPronunciations and a minimal pytest to confirm that (run with make check as outlined in Makefile).

From what I can tell, the hardest part of transitioning to python3 is getting the chr/ord bytes/str dict lookups correct. I picked updating at get but it might be better to have changed the key.

WillForan avatar Dec 14 '23 02:12 WillForan

Hey Will, thanks for this, it looks like a good change. I'm a bit booked at the moment, but I'll try to find some time to review this later next week.

bgutter avatar Dec 14 '23 16:12 bgutter