laravel4-datatables-package icon indicating copy to clipboard operation
laravel4-datatables-package copied to clipboard

TO DO

Open ktunkiewicz opened this issue 11 years ago • 4 comments

Hello people.

I reviewed all issues that exists for this package and came to some conclusions.

In my opinion these are things that should be fixed / developed in next releases:

  • add column name escaping ( #114 #106 #94 )
  • change count functions to include column names in SQL query in some situations (for example if having is used in query).This must be carefully checked for many types of queries. (#140 , #88)
  • work on mongoDB integration. I think it will be easiest to make it work with moloquent class. ( #76 )
  • check if prefixing works fine in all situations ( #26 - i know that this is an old issue, and probably not relevant, but I left it unclosed because my intuition tells me that all these complicated DB::raw queries that are allowed now may cause problems with prefixing)

I'll start working on these issues now. * If there is anybody how have some time to help me writing or testing please tell me*

** Closed issues **

  • caching of queries between two count operations causes some weird situations, the cache should be cleared after counts ( #109 #85 ) - * removed caching between counts - couldn't find any better method,I failed to find a method of clearing cache between queries as Laravel cache helper didn't work inside this method*

ktunkiewicz avatar Jul 25 '14 07:07 ktunkiewicz

Hi,

I just released an small extension for MongoDB of your package: https://github.com/merlosy/php-mongo-datatables It uses your latest release with datatables 1.9 (still need to update this one).

Everything seems to be working so far.. I tried as simple query as below

public function getData()
    {
        $users = User::select(array('_id', 'name', 'email', 'created_at'));

        return MongoDatatables::of($users)->make();
    }

And it displays just fine.

Do you think there is a way to merge our work?

Cheers

merlosy avatar Jul 25 '14 15:07 merlosy

It look like your package is based on the same code so it should be easy to apply your changes into this package. I don't see any filtering or sorting functions in your package, this may be troublesome but I was planing to do it anyway. Maybe you can make a fork of this package and try to apply some basic changes and if it will work fine I'll marge it into this project. What do you think about it?

ktunkiewicz avatar Jul 25 '14 19:07 ktunkiewicz

** Closed issue with "caching of queries" **

I removed caching between counts - couldn't find any better method,I failed to find a method of clearing cache between queries as Laravel cache helper didn't work inside this method.

ktunkiewicz avatar Sep 18 '14 07:09 ktunkiewicz

Updated issue "change count functions" description. This seems to work much better after last changes, but there is still problem if you use having clause in your query (#140)

ktunkiewicz avatar Sep 18 '14 08:09 ktunkiewicz