latex-therefore icon indicating copy to clipboard operation
latex-therefore copied to clipboard

es-export-bulk can not support 5.x since search_type=scan is not avialable

Open zqben402 opened this issue 8 years ago • 16 comments

Hi I am using es-export-bulk in 5.x but it has some compatibility issue. The search_type=scan is not available anymore in 5.x.

zqben402 avatar Jun 16 '17 03:06 zqben402

I forked the project and upgraded to the newest elasticsearch-js library and removed the search_type property. I've tested the changes successfully with my local 5.4.1 elasticsearch installation.

jurigis avatar Jun 30 '17 11:06 jurigis

"es-export-bulk is not recognised as internal or external command" in windows cmd ...any help?

Sujeet1604 avatar Jul 08 '17 12:07 Sujeet1604

Did you install it with the -g switch (npm install -g). You could also verify the PATH variable to contain the global install path.

jurigis avatar Jul 08 '17 13:07 jurigis

Thanks Jurigis. So I just need to uninstall and install again to apply your changes?

zqben402 avatar Jul 10 '17 06:07 zqben402

Yes. It should work.

jurigis avatar Jul 10 '17 06:07 jurigis

I tried npm uninstall -g elasticsearch-tools and npm install -g elasticsearch-tools But it still throws me the error.

zqben402 avatar Jul 10 '17 07:07 zqben402

The "npm install" should display the path where the tools are installed. Is this path in your PATH environment variable?

jurigis avatar Jul 10 '17 07:07 jurigis

I still seeing searchType: 'scan' in both https://github.com/skratchdot/elasticsearch-tools and https://github.com/jurigis/elasticsearch-tools in es-export-bulk.js.

Am I cloning the wrong version?

zqben402 avatar Jul 10 '17 07:07 zqben402

I just manually edit the es-export-bulk.js and now it works !. Thanks

zqben402 avatar Jul 10 '17 07:07 zqben402

Hi Jurigis:

I can successfully dump the document out with deleting 'scan' search type in the code. However the speed of dumping is like 7~8 times slower than before even with "sort":["_doc"] in the query.

Do you have any idea why this is slow?

zqben402 avatar Jul 13 '17 02:07 zqben402

Yeah .It worked.. I changed the PATH variable to c:/user/user_name/appdata

Sujeet1604 avatar Jul 13 '17 05:07 Sujeet1604

thanx for the fix @jurigis ! Any chance this could be merged into master?

abelsromero avatar Jan 26 '18 13:01 abelsromero

I'm not able to merge it into the master branch. Only @skratchdot could do it. I've created a pull request. But there are several pull requests with failed integration tests. Does anyone know how to fix the integration tests and who decides when to merge them into the master?

jurigis avatar Jan 27 '18 13:01 jurigis

Sorry about this. @jurigis - I just merged your request. I don't think there are any tests in this project- but it would be great if there were. I haven't actually used this since my previous job (where it was necessary). I'll try to take another look at this and clean things up. Thanks for the PR

skratchdot avatar Jan 27 '18 16:01 skratchdot

I've published a new version: [email protected]. Can you see if this is still an issue? I added a few tests today, but plan on adding more.

skratchdot avatar Jan 28 '18 07:01 skratchdot

Good work! With your new version the issue is solved. I've just tested it with my local elasticsearch installation.

jurigis avatar Jan 28 '18 07:01 jurigis