galaxytools icon indicating copy to clipboard operation
galaxytools copied to clipboard

Update of label encoder to allow storing of the model

Open paulzierep opened this issue 2 years ago • 6 comments

Something was messed with my rebase. New clean PR. This update enables the export of the label encoder as h5 model, that can be used to encode new data as well, similarly to the use of pretrained models.

paulzierep avatar Aug 16 '23 06:08 paulzierep

@bgruening @anuprulez how should the tool version be bumped here ? These tools do not follow the @TOOL_VERSION@+galaxy@SUFFIX_VERSION@ logic, they all use the @VERSION@ tag set in the main_macros.xml ?

paulzierep avatar Aug 16 '23 06:08 paulzierep

Hardcode it without macro. We need to shift to IUC standards at some point.

bgruening avatar Aug 16 '23 06:08 bgruening

@paulzierep I followed version="@VERSION@" profile="@PROFILE@" pattern while upgrading ML tools to 0.10.0. But, it should not make much difference at the moment if they will be changed according to IUC standards :)

anuprulez avatar Aug 16 '23 08:08 anuprulez

Then I would propose to use @VERSION@ from the main_macros.xml and add +galaxy@VERSION_SUFFIX@ to the tools individually

paulzierep avatar Aug 16 '23 08:08 paulzierep

added the VERSION_SUFFIX can this be merged @anuprulez @bgruening

paulzierep avatar Aug 21 '23 06:08 paulzierep

I think there are a few linting errors that need to be fixed

anuprulez avatar Sep 07 '23 11:09 anuprulez