galaxytools icon indicating copy to clipboard operation
galaxytools copied to clipboard

Allow special characters as Create text file input

Open wm75 opened this issue 3 years ago • 2 comments

This change allows arbitrary characters as tool input without compromising safety against malicious text.

The added test revealed a bug in the existing tests, which only tested against default settings.

The newly added "sanitize_text" macro may be useful for other tools here, too.

wm75 avatar Apr 06 '21 16:04 wm75

Do you want to add this sanitizer to the other tools as well?

bgruening avatar Apr 07 '21 07:04 bgruening

I'm planning to (that's why I put it into the macro file), but not in this PR.

Actually, the other tool I'd be interested in fixing soon is add_line_to_file, which lives a level higher in its own directory so using the same macro is not possible unfortunately.

wm75 avatar Apr 07 '21 13:04 wm75