bindWithDelay icon indicating copy to clipboard operation
bindWithDelay copied to clipboard

Added Minified Version and Modified filenaming scheme to jQuery Plugin standard

Open lucanos opened this issue 11 years ago • 3 comments

Added Minified Version of Plugin. Renamed files inline with a good portion of jQuery-dependent plugins.

lucanos avatar May 06 '13 16:05 lucanos

Thanks for the interest in the project. I am not sold on renaming the file, as it is directly referenced by that path in a number of places, and the github 404 page leaves something to be desired (no way to navigate through the repository afterwards or set up a redirect).

We can definitely add in the minified version though - which tool did you use for doing the minification?

bgrins avatar May 06 '13 16:05 bgrins

I suggest the renaming as it is commonly used across a large number of plugins. (It makes it very simple to organise your dependancies - anything starting jquery. must appear after jquery(.min).js.

I used http://jscompress.com/ to minify the script.

lucanos avatar May 06 '13 16:05 lucanos

I agree that it can make it easier to organize with the jquery prefix. Unfortunately I really don't want all of the incoming links or demos to start 404ing, so it may have to be a manual renaming process. I will pull in the minified file if you can update the PR to remove the renaming. If you make the changes, git add them, then do git commit --amend and git push origin master --force it should keep the history clean and update this PR in place. Let me know if this isn't explained well.

bgrins avatar May 06 '13 17:05 bgrins