Brian Grant

Results 229 comments of Brian Grant

Significant differences: We'll need to start simple and work through more complex cases to see where it breaks down. Kubernetes has a number of types of clients: admission controllers, controllers,...

Some thoughts from my morning ride before I forget the other half of them... If we look at the namespace provisioning example, the blueprint acts as a factory for stamping...

A few more thoughts after discussions today: Just supporting imperative operations on a declarative data model in versioned storage is pretty simple -- nothing new there. Compared to operating on...

I acknowledge the need to create reviewable diffs.

Some notes on current merge behavior. Thanks for the pointers. Load 3 trees: https://github.com/GoogleContainerTools/kpt/blob/main/internal/util/merge/merge3.go#L66-L104 Match objects by GKVNN: https://github.com/kubernetes-sigs/kustomize/blob/188e35fbfd5fcaee208e01027b37db11ee183b49/kyaml/kio/filters/merge3.go#L218-L232 Merge each object: https://github.com/kubernetes-sigs/kustomize/blob/master/kyaml/yaml/merge3/merge3.go#L13-L20 Conflict resolution: https://github.com/kubernetes-sigs/kustomize/blob/188e35fbfd5fcaee208e01027b37db11ee183b49/kyaml/yaml/merge3/visitor.go https://github.com/kubernetes-sigs/kustomize/blob/master/kyaml/yaml/walk/map.go#L32-L55 https://github.com/kubernetes-sigs/kustomize/blob/188e35fbfd5fcaee208e01027b37db11ee183b49/kyaml/yaml/walk/associative_sequence.go#L155 Since object...

Another potentially useful PL analogy, from @seh: CLOS. Method definitions are not tied to specific classes, just as most functions should not be tied to specific packages, and many functions...

Another issue uncovered by #3292: kustomize identifier transformers keep track of previous identifiers in annotations, but not in an idempotent manner, and it also doesn't output the annotations. With in-place...

@yuwenma Are you proposing to propagate the kpt-merge comments on identifiers to annotations? Or do the typescript and starlark SDKs make comments accessible? I would rather propagate user-oriented comments in...

Good point, @droot. As discussed in #2544, when a package is cloned, it becomes the upstream to the new downstream, even if it was a downstream to its own upstream.

Update behavior is being discussed in #3329. Guardrails are covered by #3279 and/or #3218.