Bradley Grainger

Results 332 comments of Bradley Grainger

I wonder if this could be related to race conditions noted in the link at https://github.com/mysql-net/MySqlConnector/issues/748#issuecomment-583758500. A more robust suite of unit tests may be required.

A [CI build](https://dev.azure.com/mysqlnet/MySqlConnector/_build/results?buildId=1113&view=results) just failed with the same error: ``` [xUnit.net 00:01:19.51] SideBySide.TransactionScopeTests.CommandBehaviorCloseConnection(connectionString: "UseXaTransactions=True") [FAIL] X SideBySide.TransactionScopeTests.CommandBehaviorCloseConnection(connectionString: "UseXaTransactions=True") [1m 11s] Error Message: System.Collections.Generic.KeyNotFoundException : The given key 'System.Transactions.Transaction' was not...

FWIW, the `TransactionScope` code is more complex, due to the support for distributed transactions. If you're disabling that anyway, and just using regular transactions, it's probably a lot simpler and...

It doesn't look like there's a strong uniqueness guarantee? https://referencesource.microsoft.com/#system.transactions/System/Transactions/TransactionTable.cs,237 ~~That could be a problem?~~ In practice, the hash code of each transaction appears to be set to a monotonically-increasing...

No, I haven't made any progress on investigating this.

> Side question: Is it safe to set the session isolation level using a custom query? Will that not affect reuse when the connection is returned to the pool? By...

MySqlConnector does not currently support this (but neither does MySql.Data AFAICT). Since MySQL has no built-in way to run a batch `UPDATE` SQL statement, it looks like the command would...

If you'd like to open a PR to add the support you need (with code that is entirely your original contribution and able to be licensed to this project), I'd...

(It looks like the earliest-available MySQL Docker image is `mysql:5.5.40`, which would make developing and testing this difficult.)

The client can control this on a per-result-set basis by executing `SET @@resultset_metadata=NONE|FULL;`; a connection string option may be unnecessary?