bgpkit-parser icon indicating copy to clipboard operation
bgpkit-parser copied to clipboard

Bgp4MpStateChange and Bgp4MpMessage have different field name for peer_ip

Open ties opened this issue 8 months ago • 0 comments

It seems like Bgp4MpStateChange and Bgp4MpMessage have an inconsistent name for the peer ip address, while in the MRT RFC (RFC 6396) the naming seems to be identical.

I think it would be nice to deprecate one of the names and make them consistent;

                bgpkit_parser::models::Bgp4MpEnum::StateChange(state_change) => {
                    (state_change.peer_addr, state_change.peer_asn)
                }
                bgpkit_parser::models::Bgp4MpEnum::Message(inner) => {
                    (inner.peer_ip, inner.peer_asn)
                }

ties avatar Apr 23 '25 08:04 ties