Bram Gotink

Results 31 comments of Bram Gotink

> my hope for initial "exports" support (CJS only, to begin with) is that we'd have a top-level option, something like ignoreExportsField, which in v1 defaulted to true and in...

@ljharb I've followed the naming of the pseudocode in [the node documentation](https://nodejs.org/dist/latest-v14.x/docs/api/esm.html#esm_resolver_algorithm), where it's called `env`: > PACKAGE_TARGET_RESOLVE(packageURL, target, subpath, internal, env) `default` is not part of the env according...

Yeah I can definitely understand that you want to start with minimal support and be very careful about what usecases to support and how to do so. I've made some...

I've rebased the PR and added some tests for resolving packages with `exports` defined but ignored via the options object. This should be good to review now! > Additionally, CJS...

> It'd be great to find a way to use the test projects here: https://github.com/ljharb/list-exports/tree/main/packages/tests/fixtures, since these cover a large variety of "exports" configurations. Doesn't have to be automated, but...

@ljharb > `preact/` should resolve to https://unpkg.com/browse/[email protected]/dist/preact.js. Which node version are you testing in? Any version that supports exports. I just retested with 14.12.0 and the behaviour is as I...

I've made some changes: - Updated the list-exports fixtures to include the changes discussed above. - Rewrote parts of the resolve-imports-exports file to match the Node algorithm. - Renamed `env(s)`...

Extra (pointless) push to get AppVeyor to rerun the checks. Apparently it doesn't like me first pushing my rebase onto 1.x and then changing the target branch. @ljharb I addressed...

@ljharb I've addressed all comments I've marked as resolved. I've also renamed the `ignoreExportsField` option to `exportsField` with two possible values: `'ignore'` and `'respect'`. There are some personal matters coming...

@ExE-Boss That's a great idea! It would be a great place to add options for adding/replacing the conditions as well in the future 🤔