Liam Bigelow
Liam Bigelow
Regarding testing: The main branch has been updated to have much better and more reliable tests, and it would be nice to include at least some of the Python testing...
> I'll definitely take you up on the offer of translating the integration tests to python! Grand! I'll tack that onto this branch (I just pushed a merge in from...
I think I agree with the logic from Zig there โ I think having the `python -m` prefix is fine, since Pagefind normally goes into build scripts anyway. It's been...
Hello again! Sorry for being the laggard here, I haven't had as much bandwidth recently! [This directory of node_api tests](https://github.com/CloudCannon/pagefind/tree/main/pagefind/integration_tests/node_api/node_base) would be the ideal, duplicated as a `python_tests` directory, where...
Oops! Updated the Toolproof readme to point to https://toolproof.app/docs/ But yes in any case sounds good! Agree with good enough for now :)
> Also: I've got a possible heisenbug for you in the toolproof node api tests Yeah there's something contention-ey messing with the chromium in there ๐ Currently hoping I'll one...
Done for both ๐
Alright, I went through and added the full suite of Node API Toolproof tests for this PR! It served as a good exercise to learn asyncio and get familiar with...
Excellent! I need to hop off for the afternoon, but will hopefully get a crack at the publishing tonight (NZ). Feel free to tack any golf tweaks on while youโre...
> Oh, one last thing: [`python -O`](https://docs.python.org/3/using/cmdline.html#cmdoption-O) strips assert statements. I've been treating asserts like `debug_assert!()`, but I want to make extra sure that's not a surprise. Good to know!...