Liam Bigelow

Results 342 comments of Liam Bigelow

Hi @kenmorse and @whyboris — I've landed on not adding this to the current default UI, and instead offering it as part of a new Modular UI package. A first...

Removing this from the 1.0 milestone as the Modular UI is now targeting a later release (see https://github.com/CloudCannon/pagefind/pull/382) (The modular UI as it exists is still being released and is...

This makes sense — I'll scope this out when I work on #53 👍

Hey @tyeeman 👋 I just tried this out with a default DDG browser installation and I'm not seeing any issue on the Pagefind site: ![IMG_0589](https://user-images.githubusercontent.com/40188355/235543040-2bf48ae9-82c0-46c3-acfe-b26a0cdd6296.PNG) Any other information on why...

Hi @kenmorse — I've landed on not adding this to the current default UI, and instead offering it as part of a new Modular UI package. A first look at...

Removing this from the 1.0 milestone as the Modular UI is now targeting a later release (see https://github.com/CloudCannon/pagefind/pull/382) (The modular UI as it exists is still being released and is...

Ah, no, iOS here. Let me track down an Android phone to test + replicate this on.

This looks like a reasonable change 👍 I'll roll with the span with a class. (In general, this level of styling is why the [Modular UI](https://www.npmjs.com/package/@pagefind/modular-ui) is under development, but...

_(Self note for implementation: these strings are sourced from the [translation files](https://github.com/CloudCannon/pagefind/blob/main/pagefind_ui/translations/en.json#L12C52-L16), so the default UI will need to wrap the `[COUNT]` and the `[SEARCH_TERM]` placeholders in spans before processing)_

Hmm, loading through there should work correctly if those assets exist. Typically they aren't created until `pagefind` runs after the build, but if copied into the assets directory things should...