bgloyer

Results 17 comments of bgloyer

I think i fixed this in 1edbeac7e9fe91a3bd8dea299db0c9818e28923e the problem was node.label was being set to undefined for distant nodes

I was looking through the guidelines and noticed that there wasn't much advice in general about using auto. The closest one is [ES.11](http://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#es11-use-auto-to-avoid-redundant-repetition-of-type-names) which says to use auto but not...

What is the next step for this one? If it would be useful, I could throw up a PR for the first bullet and let people throw darts at it.

> The premise of [C.65](https://github.com/isocpp/CppCoreGuidelines/blob/master/CppCoreGuidelines.md#c65-make-move-assignment-safe-for-self-assignment) is fatally flawed. If `x = std::move(x)` changes the value of `x` (from one valid value to another), `swap(x, x)` remains a no-op. Maybe not...

Is the (harder) enforcement needed? Is it true that incomplete types can't be passed by value so the rule wouldn't apply? Also, would relaxing the enforcement some by only warning...

Should F.6 be merged with [E.12](https://github.com/isocpp/CppCoreGuidelines/blob/master/CppCoreGuidelines.md#e12-use-noexcept-when-exiting-a-function-because-of-a-throw-is-impossible-or-unacceptable)? It looks like the rules have the same intent, but one is in the function section while the other in error handling.

I agreed this rule is out of place. A template should not unnecessary constrain parameters and semi-regualar could exclude valid uses. Stl vector and sort do not require semi-regular. It...