Benjamin Gilbert
Benjamin Gilbert
TFTP URLs were never intentionally supported in `coreos.inst.ignition_url`, but happened to work until 1659e126e918505e1e9184b96b7824c10e2d8d7e in FCOS 32.20200726.3.1. The URL schemes supported by Ignition and FCCT aren't directly relevant here, since...
There doesn't seem to be a maintained TFTP client library in Rust.
Okay, ready for review!
In the zfcp layout, it looks like you're hardcoding `/dev/sda`. Is that a safe assumption to make, or should we add a Butane field for specifying the `/dev/sda` part? ```yaml...
So, to be explicit: is it 100% certain that the user will always want `/dev/sda` and `/dev/dasda` respectively? Or is it possible that they'll want e.g. `/dev/sdb` or `/dev/dasdb`? If...
Please directly answer the question I asked in https://github.com/coreos/butane/issues/453#issuecomment-1652349302: is it true or false that the user will sometimes want to install on a disk other than the first one?...
> if we use boot_device sugar, it generates ignition with valid device automatically lets say for x86 it is /dev/disk/part-label/root. > However for the s390x device /dev/sd[] needs to be...
Looks good! Could you also post the expected output for each of those configs? Note that FCOS should also support these layouts, so the implementation should happen in the `fcos`...