Brian Gianforcaro

Results 72 comments of Brian Gianforcaro

Pulling the trigger while Europe is waking up / asleep :)

Since the bug has an existing test, would you mind adding that as well under `Tests/LibC`? There are some existing pthread tests there that could be used as a guide.

Do you have any numbers on how long the new precommit check takes? I’ll try it myself once I get to a real machine.

> Do you have any numbers on how long the new precommit check takes? > > I’ll try it myself once I get to a real machine. Seems pretty speedy...

> Some people don't like the grey background, so that might be removed from this PR. Could we do something more subtle, like make the font bold in these blocks?...

> > > Some people don't like the grey background, so that might be removed from this PR. > > > > > > Could we do something more subtle,...

Whoops, didn't see this on last toolchain update. Maybe we should mention this in a comment in the toolchain files... so folks don't mess it.

CC: @alimpfard might want to take a look as well.

@ScatteredRay Do you think you'll get some time to address @dtarditi's feedback?