simplisafe-rf icon indicating copy to clipboard operation
simplisafe-rf copied to clipboard

Incorrect next_bit assignment?

Open randyrossi opened this issue 7 years ago • 1 comments

https://github.com/bggardner/simplisafe-rf/blob/266d5e68d3e446fbbd7083f344c3688703a7d6cf/simplisafe/pigpio.py#L221

Should this be next_bit ^= 1 instead of next_bit ^= next_bit?. The equivalent section in the 'script' version of this method implies it should be.

randyrossi avatar Jul 05 '18 17:07 randyrossi

Yes, I believe you're right. However, I no longer have the V2 hardware so I can't test it.

bggardner avatar Jul 05 '18 19:07 bggardner