Bogdan Gavril

Results 799 comments of Bogdan Gavril

Today, the library does the following: ```csharp services.AddDistributedMemoryCache(); services.AddSingleton(); ``` So we're injecting the default, non-production friendly `IDistributedCache` alongside the L1 memory cache. We treat "bad" defaults as bugs generally,...

Wouldn't that be a breaking change @jmprieur ? I agree it's the right thing to do.

In memory caches are discussed here: https://github.com/AzureAD/microsoft-identity-web/wiki/token-cache-serialization#inmemory-vs-distributedmemory-cache-options. They are not persistent. In production a combination of L1 (memory) and persistent token cache - like Redis - (L2) is recommended.

@luismanez - thanks for the clarifications and pointing out the doc issues, I'll get them fixed. Looks like contributing to the official docs is not an easy process. Indeed the...

@jmprieur @jennyf19 - can you please review my comment in case I said smth wrong? Also, I think we need to make a few changes to the token cache doc:...

Something like: ![image](https://user-images.githubusercontent.com/12273384/149515063-aa7e0126-821f-44d2-981c-096cb028ff7b.png)

@jennyf19 - according to https://docs.microsoft.com/en-us/aspnet/core/performance/caching/distributed?view=aspnetcore-6.0#distributed-memory-cache `the Distributed Memory Cache isn't an actual distributed cache. Cached items are stored by the app instance on the server where the app is running.`...

Algorithm for resolving authority in MSAL .NET is encapsulated [here](https://github.com/AzureAD/microsoft-authentication-library-for-dotnet/blob/fac5d52f802de1c523c734b349a8e39c7d65a9f3/src/client/Microsoft.Identity.Client/Instance/Authority.cs#L49)

Just a small update on this one. In MSAL.NET we're deprecating this feature, and replacing it with: - an API to change just the tenant, not the whole authority -...