Ben Gamari comments

Results 254 comments of


                                            Ben Gamari

Use bsd_closefrom.c from openssh-portable to fix #189

It does seem like a nice improvement; it would be great to get it upstream.

Use bsd_closefrom.c from openssh-portable to fix #189

Looks good save one small question.

Use bsd_closefrom.c from openssh-portable to fix #189

Do let me know when you would like a review on this, @thomasjm .

testsuite: Add process-fork-wait test

Sure, I would be happy to handle it myself. Thanks for the quick feedback.

`waitForProcess` throws a `NoSuchThing` exception if the process completes too quickly.

Any further updates on this, @ProofOfKeags ?

First naive attempt to generalise the API to support different textual representations

This looks quite reasonable to me.

First naive attempt to generalise the API to support different textual representations

@adinapoli, do you need any help with this?

First naive attempt to generalise the API to support different textual representations

No worries; just let me know if you get stuck.

First naive attempt to generalise the API to support different textual representations

@adinapoli, quite understandable. It's hard to reduce GHC's use of the pretty-printer to a nice clean benchmark. The bit of GHC that is likely dependent upon pretty-printer performance is the...

First naive attempt to generalise the API to support different textual representations

Indeed in principle moving to a new pretty-printing library should be fairly straightforward. @bollu is currently trying to do this in [D3650](https://phabricator.haskell.org/D3650). Unfortunately, these sorts of things are never as...