Benoit Gagnon

Results 29 comments of Benoit Gagnon

I ran it through the debugger and can confirm the following when `insecure_skip_verify` is `true`: - `state.VerifiedChains` is empty - `lastChainExpiry` retains its uninitialized value of `time.Time{}` - once converted...

My conclusion is that: * `state.PeerCertificates` is always available * `state.VerifiedChains` is available only when `insecure_skip_verify` is `false` * `probe_ssl_last_chain_expiry_timestamp_seconds` should not be given a value when `state.VerifiedChains` is unavailable

> what exactly is it that you're trying to test here? I don't care that the container in which blackbox_exporter runs does not have the exact same CA bundle(s) that...

Agreed. Now, shouldn't `probe_ssl_last_chain_expiry_timestamp_seconds` be excluded from the metrics when verification is off?

I updated the PR to use `IsZero()` as the condition instead of poking in the module configuration.

Good question. I suppose I would use a keyboard shortcut which would bring up a small "Filter Out" menu for the currently selected line. It would offer: - exclude function...

+1 for the general idea, especially in light of troubles dealing with image sequences (#684); spawning hundreds of subprocesses on Windows to loop over long image lists add a lot...

I like this idea! We’ve built a custom controller that watches IngressRoute objects and automatically requests a matching certificate from our PKI CertSrv server (it’s a Windows server thing). We’ve...

Logrus has a built-in JSON formatter, so this should be trivial to implement: https://github.com/sirupsen/logrus#formatters Just need to agree on the CLI flag name.

> if contour is outputting so much information that it needs to be consumed and analyzed by ELK, then it should become more circumspect, not change the format to make...