geometry icon indicating copy to clipboard operation
geometry copied to clipboard
verified publisher icon bfoz

Line interception

Open fabianfiorotto opened this issue 11 years ago • 3 comments

Well ... this is my interception method. Whatever you think I should change just tell me.

fabianfiorotto avatar Dec 17 '14 12:12 fabianfiorotto

Thanks. We're off to a good start. I have a few comments...

  • Can you rebase this and squash it into a single commit?
  • Can we use fewer return statements in Line#intersection?
  • Likewise with 'self'
  • I'm trying to slowly migrate away from using 'assert_equals'-style tests in favor of 'must_equal'
  • Feel free to add blank lines between the example blocks. I'm not sure why I didn't do that originally.

Thanks for taking care of this. It's almost ready to go.

bfoz avatar Dec 20 '14 00:12 bfoz

Any reason this is not yet merged to master? Seems legit to me, and most certainly a useful feature.

I am debating using this library for re-implementation of my laser-cutter gem, since I had to build my own geometry objects, but I'd rather use something more feature rich and well tested.

kigster avatar May 28 '17 09:05 kigster

Because I completely forgot about it 😳 I'll try to get to it soon.

Nice gem. Why do I feel like I've heard about it somewhere? Hackaday? Let me know if you need anything for the integration.

bfoz avatar May 30 '17 18:05 bfoz