bfe icon indicating copy to clipboard operation
bfe copied to clipboard

staticcheck action not in ci job

Open kwanhur opened this issue 2 years ago • 2 comments

staticcheck had been used in bfe, but it doesn't exist in ci job steps.

Add step staticcheck on pull request and push develop, helps to improve quality of codes.

marketplace here, but it's under MIT license. Before using it, any license conflicts and CNCF policy limitations should take a care.

  • bfe under Apache License 2.0 and CNCF sandbox project

kwanhur avatar Feb 21 '22 14:02 kwanhur

Another way, just add one step run with staticcheck binary. I think it hasn't any conflicts.

kwanhur avatar Feb 25 '22 06:02 kwanhur

Advice adding staticcheck into pre-commit.

kwanhur avatar Mar 03 '22 05:03 kwanhur