Bruno Faccini
Bruno Faccini
> One comment, it looks like this enables the feature by default too. Should that be in the message? Oops, right @jolivier23 , I forgot that I had enabled it...
> I am ok with the patch and to eventually change it. The issue is that we still got a perf impact on frontera for IOPS benchmarks IIRC. If so,...
One more review turn-table, sorry guys .... To be honest I don't remember last time when I forgot to ask you reviewing again :-(
Even if mmap()'ed ULTs stacks feature seems to introduce some penalty, I would like to get this PR to land since this feature can be used at least for debugging...
> you can squash all the commits into a single one, please Ok > Since you're using an Intel e-mail address for your commits, you have to update all dates...
> just wondering, should we clean something up in this case? I can see we're persisting something above 😉 Well, I thought this kind of concern could araise when I...
> @bfaccini are you going to fix this PR to pass tests? Looks like embeding VEC_PUSH_BACK() in ASSERT() affects VEC_PUSH_BACK() execution, surprisingly for non-debug build only, preventing next vector allocation...
Well, now that I have fixed the original errors/SEGVs during "./RUNTESTS -b nondebug obj_action -s TEST0", I now get new ones/asserts/aborts, but unfortunately I am unable to reproduce any of...
> Well, now that I have fixed the original errors/SEGVs during "./RUNTESTS -b nondebug obj_action -s TEST0", I now get new ones/asserts/aborts, but unfortunately I am unable to reproduce any...
> Can somebody help ?? ???