Benjamin Fleischer

Results 405 comments of Benjamin Fleischer

Sorry about the test failures. I haven't worked on this in a while (because there's not much to do), so I guess the deps have changed in a non-pessimistic way....

@jimtreadway Would you like if I added you as a collaborator so you can help bring this completion? I've just very distracted with other things right now.

Oh, that's no good. Care to make a PR to fix it?

LGTM. I'm no longer using this package. Any hesitations to merging it without any version bump or anything?

@daveisfera pr seems to be missing attached code

that's just the actual rails logger formatter

It's well past my bedtime now. If I made a PR now, it would say: > Note: Lograge does not change the behavior of the Rails.logger. > Lograge replaces various...

On Heroku you may see double logging to STDOUT at the debug log level. Have you validated that your experience with the AS::N is related to lograge? Your code doesn't...

@zverok seems like a good pr to me. @NikoRoberts are you running this in prod?