Benjamin Fleischer
Benjamin Fleischer
seems like we just need buy-in to write a PR to fix it (and how it should fix it)
In our case I had an acceptance test that asserted the action wasn't routed ```ruby example "PATCH update" do expect { do_request }.to raise_error(ActionController::RoutingError, /No route matches/) end ``` which...
related https://github.com/jejacks0n/apitome/pull/115
@SrMouraSilva mind describing what you're fix does?
@SrMouraSilva > Is mind synonymous with lying? nope. I was asking if you could describe what behavior is fixed the the diff in the PR, since my imagination was failing...
Oh, that looks straightforward enough. Any reason you didn't add a test?
cc @oestrich
here's what I've done, something like ```ruby # NOTE: This is the only way to get query params in a POST # https://github.com/zipmark/rspec_api_documentation/blob/6.1.0/lib/rspec_api_documentation/dsl/endpoint.rb#L44-L48 all_the_includes = [ "my_things", "your_things", ].map {|element|...
I'm using the word example to mean dsl methods example and example_request. I'll see if I can write a failing test
I know someone made an upgrade guide somewhere in the repo or in an issurme but in general I think people found 8, 9, and 10 pretty hard to switch...