svelte-notifications icon indicating copy to clipboard operation
svelte-notifications copied to clipboard

Timeout parameter for notifications shouldn't be required

Open mcmxcdev opened this issue 2 years ago • 2 comments

The types for TNotifier are e.g. success(message: string, timeout: number): void, which doesn't make sense since timeout has a defined default and user doesn't change it very often on a per-use basis IMO.

Also, most of the basic examples from the README.md don't even conform to these typings, and wouldn't pass TS compilation.

mcmxcdev avatar Nov 01 '21 15:11 mcmxcdev

Do you know how to fix these? I'm very green on TypeScript, so wouldn't really be able to address it myself.

antony avatar Nov 01 '21 22:11 antony

I provided a PR for this ;)

mcmxcdev avatar Nov 02 '21 07:11 mcmxcdev