svelte-notifications icon indicating copy to clipboard operation
svelte-notifications copied to clipboard

Toast does not work

Open ambarvm opened this issue 2 years ago • 3 comments

The component does not show toast. Tried in sveltekit app and create-vite svelte app.

Steps to reproduce

  1. Create a blank sveltekit app pnpm init svelte@next my-app
  2. Copy example from readme to routes/index.svelte
  3. Run pnpm dev
  4. See error
500

String.prototype.startsWith called on null or undefined

TypeError: String.prototype.startsWith called on null or undefined
    at startsWith (<anonymous>)
    at node:internal/errors:811:19
    at Array.filter (<anonymous>)
    at node:internal/errors:809:16
    at prepareStackTrace (node:internal/errors:96:12)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1138:38)
    at Module.load (node:internal/modules/cjs/loader:981:32)
    at Function.Module._load (node:internal/modules/cjs/loader:822:12)
    at Module.require (node:internal/modules/cjs/loader:1005:19)
    at require (node:internal/modules/cjs/helpers:94:18)
  1. Refresh and button appears. Clicking button does not show toast.

Code available in https://github.com/supercoww/svelte-notifications-repro

System info

Windows 10 Node 16.6.0 pnpm 6.14.7

ambarvm avatar Sep 14 '21 11:09 ambarvm

The component works after adding '@beyonk/svelte-notifications' to optimizeDeps.exclude in vite config. The String.prototype.startsWith error still appears in sveltekit.

ambarvm avatar Sep 15 '21 03:09 ambarvm

Interesting. I've not used it with SvelteKit yet but plan to very soon. It sounds like we're doing something which isn't fully ejs compliant.

antony avatar Nov 01 '21 22:11 antony

The component works after adding '@beyonk/svelte-notifications' to optimizeDeps.exclude in vite config. The String.prototype.startsWith error still appears in sveltekit.

FWIW I was not getting an error but notifications were not displaying. Doing the above addressed the issue for me as well.

tojofo avatar Nov 10 '21 23:11 tojofo