go-storage icon indicating copy to clipboard operation
go-storage copied to clipboard

Tracking issue of GSP-970: Service Factory

Open Xuanwo opened this issue 2 years ago • 8 comments

  • GSP: https://github.com/beyondstorage/go-storage/pull/970

Steps

  • [x] https://github.com/beyondstorage/go-storage/pull/976
  • [ ] Generate factory in serivces

Xuanwo avatar Oct 28 '21 06:10 Xuanwo

The definitions have been refactored, we can build factory now.

Xuanwo avatar Nov 02 '21 07:11 Xuanwo

Let's migrate all services to factory! @Joey2132, take https://github.com/beyondstorage/go-storage/pull/997 as reference.

Xuanwo avatar Nov 10 '21 06:11 Xuanwo

Let's migrate all services to factory! @Joey2132, take #997 as reference.

Got it. Maybe we should list all services like issue #868 does?

Joey2132 avatar Nov 10 '21 06:11 Joey2132

Updated.

Xuanwo avatar Nov 10 '21 06:11 Xuanwo

Updated.

Got it. After adding test upon minio for s3, I will start to handle it.

Joey2132 avatar Nov 10 '21 06:11 Joey2132

@Joey2132 How about creating a comment yourself so that you can maintain the working progress?

Xuanwo avatar Nov 10 '21 06:11 Xuanwo

How about creating a comment yourself so that you can maintain the working progress?

Yes. In this way, I can update it by myself. So please delete it in your description. I will create another one.

Joey2132 avatar Nov 10 '21 06:11 Joey2132