laravel-self-diagnosis icon indicating copy to clipboard operation
laravel-self-diagnosis copied to clipboard

Published 20 hours ago • verified publisher icon beyondcode

Fix issue with phpredis driver

Open akalongman opened this issue 6 years ago • 6 comments

Fix issue with phpredis driver in the RedisCanBeAccessed checker

Related issue #68

akalongman avatar Jan 14 '19 11:01 akalongman

As predis has been deprecated and phpredis should be used in the future, it would be awesome if this PR could be merged 👍

stefanzweifel avatar Oct 10 '19 08:10 stefanzweifel

@stefanzweifel predis has been deprecated? Could you give some link about that?

akalongman avatar Oct 10 '19 08:10 akalongman

Deprecated might be to harsh of a word 😅 The default Redis client in Laravel 6 has changed from predis to phpredis.

  • https://laravel.com/docs/6.x/upgrade#redis-default-client
  • https://laravel.com/docs/6.x/redis

Predis has been abandoned by the package's original author and may be removed from Laravel in a future release.

Just upgraded an app to Laravel 6 and run into this issue, as we now use phpredis on production and had to disable this check.

stefanzweifel avatar Oct 10 '19 08:10 stefanzweifel

@stefanzweifel huh, I did not know :) But its good news imho, because phpredis is a way better than predis. I did comparison on real production data: https://medium.com/@akalongman/phpredis-vs-predis-comparison-on-real-production-data-a819b48cbadb

akalongman avatar Oct 10 '19 08:10 akalongman

Could this PR be added to the project? I am interested in using this fix with my laravel project.

Jackpump avatar Aug 05 '20 21:08 Jackpump

Just tested this and can confirm it's working (with PhpRedis from the PECL) :+1:

Would also love to see this merged!

WaveHack avatar Aug 14 '20 14:08 WaveHack