laravel-credentials icon indicating copy to clipboard operation
laravel-credentials copied to clipboard

Published 20 hours ago • verified publisher icon beyondcode

Fixes required for Windows functionality

Open sdonchez opened this issue 4 years ago • 1 comments

Windows can't handle TTY, so this checks the OS before setting the flag. Allows the user to configure the timeout, because 60 seconds is annoying if you're setting a lot of variables. Also allows parameters to be passed into the editor call, as Visual Studio Code, for example, requires a -w flag to block the terminal until the user is done editing.

This resolves issue #37 and #15. It coincidentally duplicates the effort in #38, since it's impossible to test without that fix. Kudos to @b0ric for the tty check conditions in #15.

Co-Authored-By: andrewkurzweil [email protected]

sdonchez avatar Jan 10 '21 00:01 sdonchez

@mpociot Is there anything I can do to help get this merged?

sdonchez avatar Feb 09 '21 20:02 sdonchez