herd-community icon indicating copy to clipboard operation
herd-community copied to clipboard

[Bug]: Nginx for secure configuration does not inherit the memory configuration

Open abdusfauzi opened this issue 4 months ago • 1 comments

Platform

macOS

Operating system version

macOS Sequoia 15.6

System architecture

ARM64 (M1, M2, etc)

Herd Version

1.21.2 (Build 51)

PHP Version

PHP 8.3.24

Bug description

I have set the memory on the settings interface to 10240 (MB), and I can see that it updates the herd.conf for Nginx. However, when I enabled https using herd secure, the value for client_max_body_size in valet/Nginx/domain.test was not updated. It is still using 1024M.

I have an app that need to upload huge video file. So, Nginx return error 413 Content Too Large.

Steps to reproduce

  1. Set higher memory limit in Herd > Settings > PHP > Max Upload File Size.
  2. Run command in terminal herd secure to produce local SSL for the app.
  3. Upload anything that is beyond 1024M (mb).

Relevant log output

<html>
<head><title>413 Request Entity Too Large</title></head>
<body>
<center><h1>413 Request Entity Too Large</h1></center>
<hr><center>nginx/1.25.4</center>
</body>
</html>
<!-- a padding to disable MSIE and Chrome friendly error page -->
<!-- a padding to disable MSIE and Chrome friendly error page -->
<!-- a padding to disable MSIE and Chrome friendly error page -->
<!-- a padding to disable MSIE and Chrome friendly error page -->
<!-- a padding to disable MSIE and Chrome friendly error page -->
<!-- a padding to disable MSIE and Chrome friendly error page -->

abdusfauzi avatar Aug 14 '25 06:08 abdusfauzi

Sorry for the late reply but I just wanted to let you know that I can reproduce the issue and that it also happens when isolating a site, so everytime when a new site-specific nginx conf gets created, it uses the standard at 1024MB

sschlein avatar Sep 10 '25 11:09 sschlein