expose icon indicating copy to clipboard operation
expose copied to clipboard

[2.0.1] You are not allowed to specify custom subdomains

Open PhilETaylor opened this issue 4 years ago • 2 comments

expose share http://127.0.0.1 gives:

Screenshot 2021-06-22 at 10 33 25

Note that it "thinks" that http is a custom domain... its not, its the protocol of the local site to share (as per the documentation)

PhilETaylor avatar Jun 22 '21 09:06 PhilETaylor

expose share http://localhost:3000 from the documentation gives:

Trying to use custom domain: httplocalhost

which is obviously wrong too :)

PhilETaylor avatar Jun 22 '21 09:06 PhilETaylor

Right, we should try and strip the protocol, if present to generate the automatic slug: https://github.com/beyondcode/expose/blob/master/app/Commands/ShareCommand.php#L41-L42

mpociot avatar Jun 22 '21 10:06 mpociot