eskom-calendar icon indicating copy to clipboard operation
eskom-calendar copied to clipboard

Published 20 hours ago • verified publisher icon beyarkay

Fix: Errors in Mangaung

Open IamC8 opened this issue 1 year ago • 7 comments

It is: Stage: 1 Group: 3 Wednesday 06:00-10:30 Should be: Stage: 1 Group: 3 Wednesday 06:00-08:30

It is: Stage: 2 Group: 3 Wednesday 06:00-10:30 Should be: Stage: 2 Group: 3 Wednesday 06:00-08:30

It is: Stage: 3 Group: 3 Wednesday 06:00-10:30 Should be: Stage: 3 Group: 3 Wednesday 06:00-08:30

It is: Stage: 4 Group: 3 Wednesday 06:00-10:30 Should be: Stage: 4 Group: 3 Wednesday 06:00-08:30

It is: Stage: 1 Group: 4 Friday 04:00-08:30 Should be: Stage: 1 Group: 4 Friday 04:00-06:30

It is: Stage: 2 Group: 4 Friday 04:00-08:30 Should be: Stage: 2 Group: 4 Friday 04:00-06:30

It is: Stage: 3 Group: 4 Friday 04:00-08:30 Should be: Stage: 3 Group: 4 Friday 04:00-06:30

It is: Stage: 4 Group: 4 Friday 04:00-08:30 Should be: Stage: 4 Group: 4 Friday 04:00-06:30

It is: Stage: 1 Group: 5 Friday 06:00-10:30 Should be: Stage: 1 Group: 5 Friday 06:00-08:30

It is: Stage: 2 Group: 5 Friday 06:00-10:30 Should be: Stage: 2 Group: 5 Friday 06:00-08:30

It is: Stage: 3 Group: 5 Friday 06:00-10:30 Should be: Stage: 3 Group: 5 Friday 06:00-08:30

It is: Stage: 4 Group: 5 Friday 06:00-10:30 Should be: Stage: 4 Group: 5 Friday 06:00-08:30

It is: Stage: 1 Group: 6 Friday 08:00-12:30 Should be: Stage: 1 Group: 6 Friday 08:00-10:30

It is: Stage: 2 Group: 6 Friday 08:00-12:30 Should be: Stage: 2 Group: 6 Friday 08:00-10:30

It is: Stage: 3 Group: 6 Friday 08:00-12:30 Should be: Stage: 3 Group: 6 Friday 08:00-10:30

It is: Stage: 4 Group: 6 Friday 08:00-12:30 Should be: Stage: 4 Group: 6 Friday 08:00-10:30

IamC8 avatar Jun 08 '23 19:06 IamC8

I have fixed them. Where can I upload the csv files?

IamC8 avatar Jun 08 '23 20:06 IamC8

Hey, sorry got swamped in some master's work. Could you open a PR which adds the CSVs to generated/? Have a look at this commit f655e7a71093b77a86162171f4a5516d3864862c and 93b5a7b340fe853954442dd47ff477ddaebf2063 for an example. Each group is a different CSV file.

Also can you give me a link to the source of information? I'll need to add that to area_metadata.yaml (although doing so is a bit more involved so it'll be easier for me to do it)

beyarkay avatar Jun 15 '23 13:06 beyarkay

Done

IamC8 avatar Jun 15 '23 20:06 IamC8

Was this the PR you opened? https://github.com/beyarkay/eskom-calendar/pull/448 for this issue? it looks like the PR didn't change any files: https://github.com/beyarkay/eskom-calendar/pull/448/commits/38c89abe4fbe44bf9cebcd96320c2e3085c3781c

beyarkay avatar Jun 26 '23 18:06 beyarkay

Hi, no. That was a first try that went wrong. It should be https://github.com/IamC8/eskom-calendar/commit/a083d173c17096b369256967865173cb4d0623f6

IamC8 avatar Jun 26 '23 20:06 IamC8

Also a reminder about providing the source of information (a URL is fine) so I can verify everything is correct.

beyarkay avatar Jun 28 '23 14:06 beyarkay

https://www.centlec.co.za/LoadShedding/LoadSheddingDocuments

IamC8 avatar Jun 30 '23 17:06 IamC8