Add handling for more `naga` capabilities

Open trolleyman opened this issue 2 years ago • 2 comments

Objective

Following on from https://github.com/bevyengine/bevy/pull/4824, this MR adds the capabilities for:

MULTISAMPLED_SHADING
TEXTURE_FORMAT_16BIT_NORM
MULTIVIEW
EARLY_DEPTH_TEST

Solution

RenderAdapter is passed down, and then downlevel flags are translated into capabilities that are passed into wgpu.

shader_prepass example has been changed to show that multisampled shading now works, by adding a controller for MSAA. The text color changes have also been removed, as otherwise the text couldn't be seen on the motion vectors screen.

Changelog

Added support for more naga capabilities.

Migration Guide

PipelineCache::new now takes a RenderAdapter.

Jun 29 '23 20:06 trolleyman

Resolved changes with #5703

Jul 01 '23 11:07 trolleyman

@IceSentry Thanks for the response - I've just fixed the merge conflict.

Oct 07 '23 18:10 trolleyman

This will be superseded by https://github.com/gfx-rs/wgpu/pull/5606 once we upgrade to wgpu 0.20 #13186.

May 03 '24 17:05 JMS55

@JMS55 should we pursue this or simply close it out in favor of the linked PR?

May 16 '24 15:05 alice-i-cecile

Close it in favor of the wgpu update PR, but we have to remember to make the change in that PR.

May 16 '24 19:05 JMS55