bevy icon indicating copy to clipboard operation
bevy copied to clipboard

Published 20 hours ago • verified publisher icon bevyengine

ci able to override how example runs

Open shuoli84 opened this issue 1 year ago • 10 comments

Objective

  • provide extra features to example

shuoli84 avatar Mar 02 '23 03:03 shuoli84

This pr is a follow up for #7825 , will merge after #7825 merged.

shuoli84 avatar Mar 02 '23 04:03 shuoli84

#7825 is now merged :) This looks to test the failing debug_asset_server example in CI?

alice-i-cecile avatar Mar 02 '23 13:03 alice-i-cecile

#7825 is now merged :) This looks to test the failing debug_asset_server example in CI?

Yap, this runs the example "load_gltf" with "debug_asset_server" feature enabled in existing "run-examples" flow. Now it checks whether there is a example_name.sh file, if yes, then just launch that script, otherwise fallback to standard cargo run

shuoli84 avatar Mar 02 '23 13:03 shuoli84

Hmm, it seems there are multiple places with run-examples, and the running argument is kinda different...

shuoli84 avatar Mar 02 '23 13:03 shuoli84

@alice-i-cecile any idea? Is this the right way to go? I can fix the above issue by passing extra features through environment variables. hmm. Or is "adding extra feature for run-examples" a good thing?

shuoli84 avatar Mar 02 '23 13:03 shuoli84

I'm not personally confident on the right design here: that's why I requested review from our CI ninja @mockersf ;)

alice-i-cecile avatar Mar 02 '23 13:03 alice-i-cecile

ping

shuoli84 avatar Mar 03 '23 05:03 shuoli84

ping?

shuoli84 avatar Mar 07 '23 11:03 shuoli84

This code is getting complex enough that we should move it to a rust script rather than keep it as a CI script.

It could be quite a bit more complex, @shuoli84 do you think you can do it?

Not quite sure what do you mean by "rust script". Is there an example?

shuoli84 avatar Mar 08 '23 01:03 shuoli84

The CI script in the tools folder is a good example of this :)

alice-i-cecile avatar Mar 08 '23 03:03 alice-i-cecile

@shuoli84 are you comfortable tackling this? If not, I'm happy to add Adopt-Me to this PR and others can help pick up this work.

alice-i-cecile avatar Apr 22 '23 20:04 alice-i-cecile

@shuoli84 are you comfortable tackling this? If not, I'm happy to add Adopt-Me to this PR and others can help pick up this work.

Hi alice, I'm happy to either transfer this to other or just close it. Sorry for the late reply..

shuoli84 avatar Apr 23 '23 06:04 shuoli84

No worries, thanks for the reply. Closing this out for now but we can redo it as needed.

alice-i-cecile avatar Apr 23 '23 15:04 alice-i-cecile