bevy icon indicating copy to clipboard operation
bevy copied to clipboard

Bump gilrs version to 0.10

Open james7132 opened this issue 3 years ago • 6 comments
trafficstars

Objective

Fix #6555.

Solution

Bump gilrs version to 0.10.

james7132 avatar Nov 12 '22 14:11 james7132

gilrs 0.10 is breaking support for controllers on macOS. it has been fixed but not yet released

mockersf avatar Nov 12 '22 22:11 mockersf

Duplicate dependencies are annoying, but I have a hard time arguing they're more important than supporting major controllers.

Opened a PR with Cpal to update their windows crate https://github.com/RustAudio/cpal/pull/726, I think that should solve the duplicate dependency. Will take a while to get downstream to us and I agree that it would be worth merging before then. (Once gilrs has the macOS fix out.)

paul-hansen avatar Nov 13 '22 03:11 paul-hansen

Gilrs 0.10.1 just dropped! Should have the MacOS fix. https://crates.io/crates/gilrs/0.10.1 Also includes my fix to make wasm binary smaller and a fix for north and west buttons being flipped on Wasm too.

paul-hansen avatar Nov 13 '22 16:11 paul-hansen

bors try

james7132 avatar Nov 13 '22 21:11 james7132

could you update to 0.10.1 to ensure the 0.10.0 won't be used?

mockersf avatar Nov 13 '22 21:11 mockersf

bors r+

cart avatar Nov 15 '22 20:11 cart