bevy icon indicating copy to clipboard operation
bevy copied to clipboard

unused dep references?

Open gilescope opened this issue 3 years ago • 3 comments
trafficstars

Got a hunch ( from undepend ) that these are not needed.

gilescope avatar Sep 12 '22 08:09 gilescope

At least the bevy_reflect dependency of bevy_input is needed (see the red CI build). Did Bevy build locally after making these changes?

NiklasEi avatar Sep 12 '22 17:09 NiklasEi

We are using https://crates.io/crates/cargo-udeps in CI to detect unused dependencies

mockersf avatar Sep 12 '22 17:09 mockersf

cargo-udeps is not completely accurate. undepend works by actually compiling the source after removing candidate unused dependencies, which should be more accurate than cargo-udeps, but it seems not in this case.

bjorn3 avatar Sep 12 '22 17:09 bjorn3

bors r+

mockersf avatar Sep 18 '22 15:09 mockersf