bevy icon indicating copy to clipboard operation
bevy copied to clipboard

Published 20 hours ago • verified publisher icon bevyengine

Implement `Debug` for dynamic types

Open afonsolage opened this issue 2 years ago • 1 comments

Objective

When trying derive Debug for type that has DynamicEnum it wasn't possible, since neither of DynamicEnum, DynamicTuple, DynamicVariant or DynamicArray implements Debug.

Solution

Implement Debug for those types, using derive macro

Changelog

  • DynamicEnum, DynamicTuple, DynamicVariant and DynamicArray now implements Debug

afonsolage avatar Sep 11 '22 13:09 afonsolage

Should we not implement Debug for all the Dynamic* structs? I did not look through all the types, but for example DynamicArray also doesn't implement it.

I didn't take a look in all Dynamic* also, I just needed Debug on DynamicEnum and added. I'll update this PR and add for all those Dynamic*s

afonsolage avatar Sep 12 '22 19:09 afonsolage

bors r+

alice-i-cecile avatar Sep 19 '22 15:09 alice-i-cecile

Build failed (retrying...):

bors[bot] avatar Sep 19 '22 16:09 bors[bot]

Build failed (retrying...):

bors[bot] avatar Sep 19 '22 16:09 bors[bot]

Pull request successfully merged into main.

Build succeeded:

bors[bot] avatar Sep 19 '22 16:09 bors[bot]