Inputs are not processed correctly if key repeat rate is faster than FPS

[geirsagberg]

Bevy version

0.8.1

[Optional] Relevant system information

Mac OS Monterey 12.5.1

`AdapterInfo { name: "AMD Radeon Pro 5500M", vendor: 0, device: 0, device_type: DiscreteGpu, backend: Metal }`

What you did

I have my key repeat rate set faster than normal, by following this StackOverflow thread, specifically:

defaults write -g KeyRepeat -int 1 # normal minimum is 2 (30 ms)

What went wrong

When I am running any Bevy game where FPS is locked (via PresentMode::Fifo or VsyncAuto), input seems to buffer up, so that when I release e.g. the arrow key, the character keeps moving for several seconds.

If I change the KeyRepeat back:

defaults write -g KeyRepeat -int 2

Then this does not happen (although there is still a tiny bit of lag, see https://github.com/bevyengine/bevy/issues/3317)

Additional information

When I set PresentMode::Immediate it mostly works as expected, although some times the FPS is still locked to screen refresh rate, though that is a separate issue (And in these cases, the exact same problem as described above is present).

[geirsagberg]

I have a feeling this is related to winit, but I don't know enough about the underlying dependency to know if it needs to be fixed there, or if it can be fixed somehow in Bevy.

[geirsagberg]

Found this related issue from winit: https://github.com/rust-windowing/winit/issues/310

[geirsagberg]

Someone else had the same problem with winit and switched to using DeviceEvent instead of WindowEvent: https://gitlab.com/veloren/veloren/-/merge_requests/3165 Which again seems to have led to a PR in winit: https://github.com/rust-windowing/winit/pull/2182

[geirsagberg]

Maybe something like https://github.com/rukai/winit_input_helper could be used?

[geirsagberg]

I suspect this is the same problem as in https://github.com/bevyengine/bevy/issues/4664

[senicko]

Are there any updates on that? I am experiencing a simillar problem and would like to fix it somehow.