bevy icon indicating copy to clipboard operation
bevy copied to clipboard

changed diagnostics from seconds to milliseconds

Open McSpidey opened this issue 1 year ago • 2 comments

Co-authored-by: Alice Cecile [email protected]

Objective

Change frametimediagnostic from seconds to milliseconds because this will always be less than one seconds and is the common unit for game engines.

Solution

  • multiplied the existing value by 1000

Changelog

Frametimes are now reported in milliseconds

McSpidey avatar Aug 02 '22 22:08 McSpidey

As someone not accustomed to other game engine, seconds is the natural unit for a duration, not milliseconds. Very quick google search seems to show in seconds for unreal, not sure about unity

mockersf avatar Aug 02 '22 22:08 mockersf

Unreal and Unity both use milliseconds for frametimes. https://docs.unrealengine.com/4.27/en-US/TestingAndOptimization/PerformanceAndProfiling/Overview/ https://docs.unity3d.com/Manual/ProfilerCPU.html

McSpidey avatar Aug 02 '22 23:08 McSpidey

You're right, for displaying, milliseconds makes a lot more sense.

I was looking for the unit used when accessing timings from code, for that I found seconds

mockersf avatar Aug 03 '22 16:08 mockersf

bors r+

cart avatar Aug 04 '22 22:08 cart

bors r-

cart avatar Aug 04 '22 22:08 cart

Canceled.

bors[bot] avatar Aug 04 '22 22:08 bors[bot]

bors r+

cart avatar Aug 04 '22 22:08 cart