bevy icon indicating copy to clipboard operation
bevy copied to clipboard

Winit 0.27 update

Open Aceeri opened this issue 1 year ago • 6 comments

Objective

  • ~~This is just a pre-emptive PR for the next winit version~~
  • Update winit dependency to 0.27

Solution


Changelog

  • Changed cursor_locked to cursor_grab_mode and created a CursorGrabMode enum similar to winit's.

Migration Guide

  • Will need to change the true/false of WindowDescriptors for cursor_locked to CursorGrabMode::Locked.

Could add this is we want

impl From<bool> for CursorGrabMode {
    fn into(self) -> CursorGrabMode {
        if self { CursorGrabMode::Locked } else { CursorGrabMode::None }
    }
}

Aceeri avatar Jul 17 '22 00:07 Aceeri

winit 0.27 has been released but this is still blocked on wgpu updating its raw-window-handle dep here: https://github.com/gfx-rs/wgpu/pull/2918

Aceeri avatar Aug 01 '22 02:08 Aceeri

Do note that because of it being a public dependency wgpu cannot release a patch to rwh 0.5, so this will have to wait till wgpu 0.14 in late september.

cwfitzgerald avatar Aug 01 '22 02:08 cwfitzgerald

@cwfitzgerald No worries, this missed the bevy 0.8 release anyways and late september still falls solidly into the bevy 0.9 release window I think.

Aceeri avatar Aug 01 '22 02:08 Aceeri

Could you also update ndk-glue? It needs to be kept in sync with winit

mockersf avatar Aug 01 '22 07:08 mockersf

By the way, updating ndk glue to 0.7 would (probably) not resolve #3648, since cpal still uses 0.6.

harudagondi avatar Aug 02 '22 03:08 harudagondi

@harudagondi I'll put in a quick PR to them to update to 0.7 so we can fix both of em.

Aceeri avatar Aug 02 '22 23:08 Aceeri

@Aceeri What is the status of this? Still blocked?

Weibye avatar Aug 27 '22 10:08 Weibye

Ya this will prob be blocked for another month or so for wgpu stuff. We could use a git revision if we wanted in the mean time I suppose

Aceeri avatar Aug 27 '22 21:08 Aceeri

For visibility, here's another update attempt: https://github.com/bevyengine/bevy/pull/6086

frewsxcv avatar Sep 29 '22 19:09 frewsxcv

wgpu 0.14 (and naga 0.10) have been published!

mockersf avatar Oct 05 '22 23:10 mockersf

@Aceeri any chance you can pick up the updates soon?

mockersf avatar Oct 07 '22 21:10 mockersf

@mockersf Ya, been just a bit tied up in trying to get spring forces that don't become unstable with bad user inputs but I'll work on gettin this back into shape this week.

Aceeri avatar Oct 07 '22 23:10 Aceeri

Closing in favor of #6218, which is nearly ready to merge :) Thanks for scouting this out!

alice-i-cecile avatar Oct 19 '22 14:10 alice-i-cecile