bevy
bevy copied to clipboard
Winit 0.27 update
Objective
- ~~This is just a pre-emptive PR for the next winit version~~
- Update winit dependency to 0.27
Solution
Changelog
- Changed
cursor_locked
tocursor_grab_mode
and created aCursorGrabMode
enum similar to winit's.
Migration Guide
- Will need to change the
true
/false
ofWindowDescriptor
s for cursor_locked toCursorGrabMode::Locked
.
Could add this is we want
impl From<bool> for CursorGrabMode {
fn into(self) -> CursorGrabMode {
if self { CursorGrabMode::Locked } else { CursorGrabMode::None }
}
}
winit 0.27 has been released but this is still blocked on wgpu updating its raw-window-handle dep here: https://github.com/gfx-rs/wgpu/pull/2918
Do note that because of it being a public dependency wgpu cannot release a patch to rwh 0.5, so this will have to wait till wgpu 0.14 in late september.
@cwfitzgerald No worries, this missed the bevy 0.8 release anyways and late september still falls solidly into the bevy 0.9 release window I think.
Could you also update ndk-glue
? It needs to be kept in sync with winit
By the way, updating ndk glue to 0.7 would (probably) not resolve #3648, since cpal still uses 0.6.
@harudagondi I'll put in a quick PR to them to update to 0.7 so we can fix both of em.
@Aceeri What is the status of this? Still blocked?
Ya this will prob be blocked for another month or so for wgpu stuff. We could use a git revision if we wanted in the mean time I suppose
For visibility, here's another update attempt: https://github.com/bevyengine/bevy/pull/6086
@Aceeri any chance you can pick up the updates soon?
@mockersf Ya, been just a bit tied up in trying to get spring forces that don't become unstable with bad user inputs but I'll work on gettin this back into shape this week.
Closing in favor of #6218, which is nearly ready to merge :) Thanks for scouting this out!