bevy icon indicating copy to clipboard operation
bevy copied to clipboard

Add more examples and tests for run criteria

Open alice-i-cecile opened this issue 2 years ago • 4 comments

Currently there are no examples and limited tests for these.

We should add both.

alice-i-cecile avatar Feb 28 '22 19:02 alice-i-cecile

There's some tests here: https://github.com/bevyengine/bevy/blob/6615b7bf6439c9bcaf59982b2713e1c1564bf0f5/crates/bevy_ecs/src/schedule/stage.rs#L1432-L1562

hymm avatar Feb 28 '22 19:02 hymm

#7652 adds an example for run conditions, and though it seems like the tests that @hymm are no longer there after stageless's merge. Perhaps we should add those tests back in.

james7132 avatar Feb 20 '23 01:02 james7132

I'm happy to add in some more tests, would theses go the conditions.rs file? https://github.com/bevyengine/bevy/blob/main/crates/bevy_ecs/src/schedule/condition.rs

LiamGallagher737 avatar Mar 10 '23 07:03 LiamGallagher737

Yes please, I would add a mod tests there.

alice-i-cecile avatar Mar 10 '23 12:03 alice-i-cecile