bevy icon indicating copy to clipboard operation
bevy copied to clipboard
verified publisher icon bevyengine

Replace `FULLSCREEN_SHADER_HANDLE` with a `FullscreenShader` resource.

Open andriyDev opened this issue 7 months ago • 3 comments

Objective

  • Related to #19024.

Solution

  • Remove the FULLSCREEN_SHADER_HANDLE weak_handle with a resource holding the shader handle.
    • This also changes us from using load_internal_asset to embedded_asset/load_embedded_asset.
  • All uses have been migrated to clone the FullscreenShader resource and use its to_vertex_state method.

Testing

  • anti_aliasing example still works.
  • bloom_3d example still works.

andriyDev avatar May 29 '25 04:05 andriyDev

Needs a migration guide imo, since lots of users use this.

JMS55 avatar May 29 '25 13:05 JMS55

@JMS55 I already added a migration guide for this? Is there more to do there?

andriyDev avatar May 29 '25 14:05 andriyDev

Oh whoops, I missed that.

Might be nice to add an example of the before/after changes needed, though.

JMS55 avatar May 29 '25 15:05 JMS55