bevy icon indicating copy to clipboard operation
bevy copied to clipboard

one shot system cleanup

Open pemattern opened this issue 1 year ago • 3 comments

Objective

  • Fixes #16497
  • This is my first PR, so I'm still learning to contribute to the project

Solution

  • Added struct UnregisterSystemCached and function unregister_system_cached
  • renamed World::run_system_with_input to run_system_with
  • reordered input parameters for World::run_system_once_with

Testing

  • Added a crude test which registers a system via World::register_system_cached, and removes it via Command::unregister_system_cached.

Migration Guide

  • Change all occurrences of World::run_system_with_input to World::run_system_with.
  • swap the order of input parameters for World::run_system_once_with such that the system comes before the input.

pemattern avatar Nov 26 '24 10:11 pemattern

Welcome, new contributor!

Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨

github-actions[bot] avatar Nov 26 '24 10:11 github-actions[bot]

It looks like your PR is a breaking change, but you didn't provide a migration guide.

Could you add some context on what users should update when this change get released in a new version of Bevy? It will be used to help writing the migration guide for the version. Putting it after a ## Migration Guide will help it get automatically picked up by our tooling.

github-actions[bot] avatar Nov 26 '24 14:11 github-actions[bot]

I added a migration guide.

pemattern avatar Nov 26 '24 19:11 pemattern