bevy
bevy copied to clipboard
one shot system cleanup
Objective
- Fixes #16497
- This is my first PR, so I'm still learning to contribute to the project
Solution
- Added struct
UnregisterSystemCachedand functionunregister_system_cached - renamed
World::run_system_with_inputtorun_system_with - reordered input parameters for
World::run_system_once_with
Testing
- Added a crude test which registers a system via
World::register_system_cached, and removes it viaCommand::unregister_system_cached.
Migration Guide
- Change all occurrences of
World::run_system_with_inputtoWorld::run_system_with. - swap the order of input parameters for
World::run_system_once_withsuch that the system comes before the input.
Welcome, new contributor!
Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨
It looks like your PR is a breaking change, but you didn't provide a migration guide.
Could you add some context on what users should update when this change get released in a new version of Bevy?
It will be used to help writing the migration guide for the version. Putting it after a ## Migration Guide will help it get automatically picked up by our tooling.
I added a migration guide.