bevy icon indicating copy to clipboard operation
bevy copied to clipboard

Add `EntityMut::get_mut_by_id_unchecked`

Open alice-i-cecile opened this issue 1 year ago • 1 comments

I still think there should be a get_mut_by_id_unchecked. The apis added in #15593 could end up allocating in some tight loops which would be a perf footgun. The unchecked version would allow users to implement their own versions in userspace that could reuse the allocations.

Originally posted by @hymm in #15577

alice-i-cecile avatar Oct 02 '24 19:10 alice-i-cecile

I intend to work on this if no one else gets to it first

BenjaminBrienen avatar Oct 13 '24 21:10 BenjaminBrienen

it was also suggested that a variant checking unicity though a hashset could be better: https://github.com/bevyengine/bevy/issues/15577#issuecomment-2387108509

mockersf avatar Nov 10 '24 00:11 mockersf